Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drag handle mouse cursor #9906

Closed
AdRiley opened this issue May 9, 2024 · 2 comments · Fixed by #9982
Closed

Add drag handle mouse cursor #9906

AdRiley opened this issue May 9, 2024 · 2 comments · Fixed by #9982
Assignees
Labels
-gui d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint x-new-feature Type: new feature request
Milestone

Comments

@AdRiley
Copy link
Member

AdRiley commented May 9, 2024

When my mouse is hovered over an area that I can use to drag a component round (component icon/drag halo) it should change to a drag cursor so that I know.

@AdRiley AdRiley added x-new-feature Type: new feature request -gui labels May 9, 2024
@AdRiley AdRiley added this to the Beta Release milestone May 9, 2024
@farmaazon farmaazon added d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints p-high Should be completed in the next sprint and removed p-medium Should be completed in the next few sprints labels May 9, 2024
@farmaazon
Copy link
Contributor

farmaazon commented May 9, 2024

Refinement:

  • Node background should set "grab". Every widget which has different interaction should change cursor by itself (clicking is more important than drag).
  • When moving node, the cursor should be grabbing
  • Vector Editor handle should use the same cursor.
  • To consider: maybe change cursor to grabbing only when actually dragging node? Because clicking on a node can do other actions than just dragging.

@farmaazon farmaazon self-assigned this May 17, 2024
@farmaazon farmaazon mentioned this issue May 17, 2024
4 tasks
@enso-bot
Copy link

enso-bot bot commented May 17, 2024

Adam Obuchowicz reports a new STANDUP for today (2024-05-17):

Progress: Gave up with integrating react tooltips, instead took two next small tasks: changing cursor pointer shape on node and drag, and icon highlight. The first is done: did two versions to check what is better. Icons are also almost done, just need testing all icons in our app (as I refactored a bit to make general SvgButton component). It should be finished by 2024-05-24.

Next Day: Next day I will be working on the #9904 task. Finish hovering icons and start next task.

mergify bot pushed a commit that referenced this issue May 20, 2024
Fixes #9906, but the grab hand appears only when actually moving nodes.

Also changed cursor on some widgets.
@mergify mergify bot closed this as completed in #9982 May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint x-new-feature Type: new feature request
Projects
Status: 🟢 Accepted
Development

Successfully merging a pull request may close this issue.

2 participants