Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Per source group configuration might not be included in the reports #1113

Open
zregvart opened this issue Oct 23, 2023 · 1 comment
Open

Per source group configuration might not be included in the reports #1113

zregvart opened this issue Oct 23, 2023 · 1 comment

Comments

@zregvart
Copy link
Member

Seems probable based on the failure of the e2e tests in EC update.
@zregvart zregvart mentioned this issue Oct 23, 2023
Merged
lcarva added a commit to lcarva/ec-cli that referenced this issue Nov 7, 2023
@lcarva
Add test for config per policy source
42bb5cc 
Relates enterprise-contract#1113

Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
@lcarva lcarva mentioned this issue Nov 7, 2023
Merged
@lcarva
Copy link
Member

lcarva commented Nov 7, 2023 •
edited

The problem here is that the e2e-tests are using a version of the enterprise-contract-controller which does not have support for the per source group config.

Since this issue was reported, the test case was removed from the e2e tests under the premise that we already have sufficient coverage for it. Regardless, I'm gonna update the version of the controller there to avoid this happening again in the future.

NOTE: It may be worth considering providing versions for the controller so consumers can leverage dependabot/renovatebot to bring in updates, see enterprise-contract/enterprise-contract-controller#217.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zregvart @lcarva