Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warning from "importlib_metadata" #952

Closed
rahulporuri opened this issue Jun 15, 2021 · 5 comments · Fixed by #991 or #994
Closed

Deprecation warning from "importlib_metadata" #952

rahulporuri opened this issue Jun 15, 2021 · 5 comments · Fixed by #991 or #994
Labels
difficulty: easy Issues which don't need much/any context about the package. Good First Issue
Projects
Enthought OSS Q3 2021

Comments

@rahulporuri
Copy link
Contributor 

 /Users/runner/work/chaco/chaco/.edm/envs/chaco-test-3.6-pyqt5/lib/python3.6/site-packages/pyface/base_toolkit.py:216: DeprecationWarning: SelectableGroups dict interface is deprecated. Use select.
  entry_point_group = importlib_metadata.entry_points()[entry_point]
@rahulporuri
Copy link
Contributor Author

rahulporuri commented Jun 15, 2021 •
edited

ref https://importlib-metadata.readthedocs.io/en/latest/history.html#v3-9-0

IIUC, the recommended usage is importlib_metadata.entry_points().select(entry_point).

@rahulporuri rahulporuri added difficulty: easy Issues which don't need much/any context about the package. Good First Issue labels Jun 30, 2021
@DiddiLeija
Copy link
Contributor

DiddiLeija commented Jul 3, 2021 •
edited

Hi, I would like to take this issue (if it is available). What do I have to do?

@rahulporuri
Copy link
Contributor Author

👋 @DiddiLeija . If you're interested in contributing to Pyface by fixing this issue, please open a PR. Like I mentioned earlier, the latest version of importlib_metadata recommends the use of importlib_metadata.entry_points().select(entry_point). Along with that change, you will also need to update the minimum required version of importlib_metadata to the version which introduced importlib_metadata.entry_points().select.

Does that answer your question about what you need to do?

@DiddiLeija
Copy link
Contributor

Ok. Maybe today or tomorrow I can check this issue. Thanks @rahulporuri for your information. I will open a PR as soon as I can.

This was referenced Jul 15, 2021
Closed
Merged
@DiddiLeija
Copy link
Contributor

@rahulporuri I created #991 to fix this issue.

@rahulporuri rahulporuri added this to To be considered in Enthought OSS Q3 2021 via automation Jul 16, 2021
@rahulporuri rahulporuri moved this from To be considered to Done in Enthought OSS Q3 2021 Jul 16, 2021
@rahulporuri rahulporuri mentioned this issue Jul 16, 2021
Merged
@rahulporuri rahulporuri moved this from Done to Sprint 1 (5 July - 16 July 2021) in Enthought OSS Q3 2021 Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy Issues which don't need much/any context about the package. Good First Issue
Projects
No open projects
Enthought OSS Q3 2021
  
Sprint 1 (5 July - 16 July 2021)
Milestone
No milestone
2 participants
@rahulporuri @DiddiLeija