Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: duplicate form field in the same form #547

Open
qutluq opened this issue Jul 2, 2023 · 3 comments · May be fixed by #574
Open

[BUG]: duplicate form field in the same form #547

qutluq opened this issue Jul 2, 2023 · 3 comments · May be fixed by #574
Labels
🐞 bug Something isn't working

Comments

@qutluq
Copy link
Contributor

qutluq commented Jul 2, 2023

Describe the bug

Navigating to the Settings tab generates duplicate form field in the same form bug on the issues tab.

Steps to reproduce

  1. Go to Settings tab.
  2. Open web developers tools by choosing Inspect from the context menu.
  3. Navigate to the issues tab.
  4. See the error message in red: "duplicate form field in the same form".

Expected behavior

There should be no such message on the issues tab.

Screenshots

Untitled2

Additional information

No response

@qutluq qutluq added the 🐞 bug Something isn't working label Jul 2, 2023
@armichaud
Copy link

@qutluq is this issue still active? I'm unable to reproduce this bug while running the dev platform app on Chrome Version 115.0.5790.114 on MacOS. As you'll see in the screenshot below, the issues tab does not flag multiple selectors with the same id. The console shows that two select tags have the same tabs value as their id, but both of these are hidden dropdowns that seem to have been replaced by newer UI features (I have disabled the sm:hidden class for those two elements in the screenshot below to highlight what I'm talking about).

Screenshot 2023-08-08 at 06 25 28

@qutluq
Copy link
Contributor Author

qutluq commented Aug 8, 2023

@armichaud apparently Google Chrome does not inform us about duplicate ids in the page anymore, as in the case of duplicate form field ids. Tried to reproduce it on my machine, and did not succeed. My version of chrome is 115.0.5790.171 (Official Build) (64-bit) on Windows 10. But, the duplicate ids are still there, you can find them by searching tabs keyword on Elements tab of Chrome dev tools on the mentioned page.

Screenshot 2023-08-08 195025

As discussed here the duplicate ids can still cause problems.

Usually developers do not recommend using the same id more than once, but since the bug is gone, we may leave it be, and close this issue.

@dahal What do you think, should we close it?

@armichaud armichaud linked a pull request Aug 8, 2023 that will close this issue
10 tasks
@armichaud
Copy link

Oh I agree in principle that there shouldn't be more than one element with the same ID attribute, I was initially unsure of the impact given that both elements were hidden by default. I've since realized that these drop-downs are visible on narrower viewports, and so the duplicate IDs should be addressed.

Since this is just a one-line fix, I went ahead and put together a PR: #574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants