-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: duplicate form field in the same form #547
Comments
@qutluq is this issue still active? I'm unable to reproduce this bug while running the dev platform app on Chrome Version 115.0.5790.114 on MacOS. As you'll see in the screenshot below, the issues tab does not flag multiple selectors with the same id. The console shows that two |
@armichaud apparently Google Chrome does not inform us about duplicate ids in the page anymore, as in the case of duplicate form field ids. Tried to reproduce it on my machine, and did not succeed. My version of chrome is 115.0.5790.171 (Official Build) (64-bit) on Windows 10. But, the duplicate ids are still there, you can find them by searching As discussed here the duplicate ids can still cause problems. Usually developers do not recommend using the same id more than once, but since the bug is gone, we may leave it be, and close this issue. @dahal What do you think, should we close it? |
Oh I agree in principle that there shouldn't be more than one element with the same ID attribute, I was initially unsure of the impact given that both elements were hidden by default. I've since realized that these drop-downs are visible on narrower viewports, and so the duplicate IDs should be addressed. Since this is just a one-line fix, I went ahead and put together a PR: #574 |
Describe the bug
Navigating to the Settings tab generates duplicate form field in the same form bug on the issues tab.
Steps to reproduce
Expected behavior
There should be no such message on the issues tab.
Screenshots
Additional information
No response
The text was updated successfully, but these errors were encountered: