Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Replace current toast with shadcn/ui toast #556

Open
dahal opened this issue Jul 19, 2023 · 1 comment
Open

[FEAT]: Replace current toast with shadcn/ui toast #556

dahal opened this issue Jul 19, 2023 · 1 comment
Labels
🥇 good first issue Good for newcomers 🙏 help wanted Extra attention is needed 🖥️ platform For envless platform

Comments

@dahal
Copy link
Member

dahal commented Jul 19, 2023

What would you like to share?

This component should be customized to accept error or success props and render current icons with colors as accordingly.

Reference

Additional information

No response

@dahal dahal added 🥇 good first issue Good for newcomers 🙏 help wanted Extra attention is needed 🖥️ platform For envless platform labels Jul 19, 2023
@armichaud
Copy link

Hi @dahal, I'd be interested in taking this on, I just wanted to get a better sense of the objective and where things are at currently. According to the documentation you linked, to implement the shadcn toast would basically just involve replacing react-hot-toast and showToast with a component that uses the @radix-ui/react-toast ToastPrimitive and the useToast hook.

What I noticed is that there is already a Toast component that makes use of the ToastPrimitive from @radix_ui/react-toast, but isn't implemented anywhere. Is the scope of this work just to implement this component in place of all instances of the react-hot-toast Toaster (or, as in the case of showToast, replace the toast.custom component)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥇 good first issue Good for newcomers 🙏 help wanted Extra attention is needed 🖥️ platform For envless platform
Projects
None yet
Development

No branches or pull requests

2 participants