Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom sample project to validate toolchain container #120

Open
sunjayBhatia opened this issue Dec 18, 2020 · 0 comments
Open

Use custom sample project to validate toolchain container #120

sunjayBhatia opened this issue Dec 18, 2020 · 0 comments

Comments

@sunjayBhatia
Copy link
Member

So we don't run into the issue we had with #117 we could override the default bazel-toolchains sample CC project that is used to build the toolchain configs with one that also emulates a foreign_cc project (with CMake scripts etc.). This would ensure less future errors when modifying the toolchain container.

See: https://github.com/bazelbuild/bazel-toolchains/blob/d1af351b18c800a81677d9b924d4458a742ed8f4/rules/rbe_repo.bzl#L65 (use a sample project we host in this repo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant