Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows build image networking is broken #255

Open
phlax opened this issue Aug 31, 2023 · 8 comments
Open

Windows build image networking is broken #255

phlax opened this issue Aug 31, 2023 · 8 comments

Comments

@phlax
Copy link
Member

phlax commented Aug 31, 2023

Any recent attempts to rebuild the Windows image succeed, but for a reason that eludes me are unable to make network connections when first started

Any attempt at retry invariably works

This problem was always there, but has gotten worse to the point of unusable

We will have to just pin the windows image in Envoy until this is resolved

@phlax
Copy link
Member Author

phlax commented Aug 31, 2023

fwiw pulling and creating the image gives it a better chance of hitting the ground running, but not sufficiently that you could call it reliable

@phlax
Copy link
Member Author

phlax commented Aug 31, 2023

the problem can be seen on main where it attempts to regenerate the toolchains - https://github.com/envoyproxy/envoy-build-tools/actions?query=branch%3Amain

i have added some CI, so that we test toolchain regeneration in PRs but that always seems to pass, not sure exactly why

im going to "fix" main by declaring windows broken_

@phlax
Copy link
Member Author

phlax commented Aug 31, 2023

the problem with this fix is that it will leave the windows build with ~1/10 chance of having its toolchains regenerated

where i have needed to test downstream i have repeatedly retested until it passed

@phlax
Copy link
Member Author

phlax commented Sep 1, 2023

checking through my previous test attempts i noticed that when i had tried pinning the base image to the earlier one i had inadvertently pinned it to current

i had another go and pinning this in #256 - but sadly same results

the one other idea which i have is to bring back #210 but this time also update the base image to 2022 as i have a feeling that the errors we got were from this mismatching - not sure the implications of changing the base image

@phlax
Copy link
Member Author

phlax commented Oct 16, 2023

strangely this seems to have resolved itself afaict

if confirmed ill remove the pin in the envoy repo

@phlax
Copy link
Member Author

phlax commented Oct 16, 2023

closing this for now

@phlax phlax closed this as completed Oct 16, 2023
@phlax phlax reopened this Oct 16, 2023
@phlax
Copy link
Member Author

phlax commented Oct 16, 2023

reopening - it still happens albeit less frequently

@phlax
Copy link
Member Author

phlax commented Jan 8, 2024

this is an ongoing problem - it happens in envoy ci (albeit ~rarely)

for whatever reason it happens very frequently here - specifically in the toolchain regeneration step (which we dont have much control over)

cc @akshaysngupta the windows toolchain hasnt been regenerated for some time - at some point its likely to start breaking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant