Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ios/android proxy: support proxy with auth #2574

Open
Augustyniak opened this issue Sep 28, 2022 · 0 comments
Open

ios/android proxy: support proxy with auth #2574

Augustyniak opened this issue Sep 28, 2022 · 0 comments

Comments

@Augustyniak
Copy link
Contributor

Augustyniak commented Sep 28, 2022

At least on iOS, system proxy settings screen does allow it users to specify login and password that should be used to authenticate with a given proxy. We should look into whether we need to support proxy auth on Android.

Screen Shot 2022-09-28 at 10 02 44 AM

^ A part of the proxy settings screen on iOS

Looking at the cronet code (networking library) - thank you @RyanTheOptimist! - it seems that we do not need to support proxy auth on Android. This is the comment that can be found in the library's code:

// - kCFProxyPasswordKey : Despite the existence of these keys in the
//                         documentation, they're never populated. Even if a
//                         username/password were to be set in the network
//                         proxy system preferences, we'd need to fetch it
//                         from the Keychain ourselves. CFProxy is such a
//                         tease.

source

@Augustyniak Augustyniak changed the title android proxy: support proxy with auth ios/android proxy: support proxy with auth Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant