Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no such package '@com_github_axboe_liburing//' building Envoy docker image #33862

Open
isaaccarrington opened this issue Apr 30, 2024 · 9 comments

Comments

@isaaccarrington
Copy link

Commit id being built - 35d00a5
Command run ./ci/run_envoy_docker.sh './ci/do_ci.sh release'
Error output

...
Analyzing: 3018 targets (1620 packages loaded, 47535 targets configured)
ERROR: /build/bazel_root/base/external/envoy/bazel/foreign_cc/BUILD:11:15: no such package '@com_github_axboe_liburing//': error globbing [**] op=FILES: /build/bazel_root/base/external/com_github_axboe_liburing/man/IO_URING_VERSION_MINOR.3 (Too many levels of symbolic links) and referenced by '@envoy//bazel/foreign_cc:liburing'
ERROR: Analysis of target '//test/common/io:io_uring_worker_factory_impl_test' failed; build aborted: 
INFO: Elapsed time: 652.907s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (1620 packages loaded, 47535 targets configured)
ERROR: Couldn't start the build. Unable to run tests
./ci/do_ci.sh: line 122: pushd: bazel-testlogs: No such file or directory

Output of bazel version

Bazelisk version: development
Build label: 6.5.0
Build target: bazel-out/darwin_arm64-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Tue Jan 23 16:45:22 2024 (1706028322)
Build timestamp: 1706028322
Build timestamp as int: 1706028322

Machine details:
MacBook Pro
14 inch, 2021
Chip: Apple M1 Pro
MacOS: Sonoma 14.4.1

@phlax
Copy link
Member

phlax commented Apr 30, 2024

cc @soulxu

@phlax
Copy link
Member

phlax commented Apr 30, 2024

@isaaccarrington can you build with the immediately previous commit ?

see below

@phlax
Copy link
Member

phlax commented Apr 30, 2024

actually - i was thinking it was this PR that had landed - #33833

not sure, but i think this may be related to the workaround i added for one of the tests breaking

@phlax
Copy link
Member

phlax commented Apr 30, 2024

either way - im reasonably confident that #33833 will fix this

@phlax
Copy link
Member

phlax commented Apr 30, 2024

@isaaccarrington i have landed the likely fix if you can confirm we can close this ticket

@isaaccarrington
Copy link
Author

Thanks @phlax but unfortunately the same error

ERROR: /build/bazel_root/base/external/envoy/bazel/foreign_cc/BUILD:11:15: no such package '@com_github_axboe_liburing//': error globbing [**] op=FILES: /build/bazel_root/base/external/com_github_axboe_liburing/man/io_uring_minor_version.3 (Too many levels of symbolic links) and referenced by '@envoy//bazel/foreign_cc:liburing'
ERROR: Analysis of target '//test/common/io:io_uring_worker_factory_impl_test' failed; build aborted: 
INFO: Elapsed time: 1300.859s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (1536 packages loaded, 30331 targets configured)
ERROR: Couldn't start the build. Unable to run tests
./ci/do_ci.sh: line 122: pushd: bazel-testlogs: No such file or directory

I actually cloned the repo fresh
Ensured you change is there

git log | grep 88388                             
commit e096fa40ef98571120a865397b15e188388bc30a
commit bdd2f63fafd7688388fb7e32bb209f2687af46e2

and deleted /tmp/envoy-docker-build

@phlax
Copy link
Member

phlax commented May 2, 2024

hmm, i see, thanks for checking

thinking more - i think that its not arm-specific as we run that command in our arm ci - so im thinking its more to do with mac

i dont have a mac to test with but i think there is some parts of the code that require select in their BUILD targets to ensure only linux triggers that code - there are some already, but most likely more are required

would be happy to review (insofar as i can) any PRs to fix that

if you got chance to test any of the release branches that would be helpful as we might be able to ~bisect the change

... and backport any fixes

@soulxu
Copy link
Member

soulxu commented May 8, 2024

not sure whether this PR is going to help #33107

@soulxu
Copy link
Member

soulxu commented May 8, 2024

not sure whether this PR is going to help #33107

emm...no, you failed on another test '//test/common/io:io_uring_worker_factory_impl_test',

but I think you can doing something similar to this one https://github.com/envoyproxy/envoy/pull/33107/files#diff-8e3c597bf96603a6c558022b88c5339e40dcb2da67375e7617db1d614f3d6226R438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants