Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support knob to configure consistent hash table size #3272

Open
aoledk opened this issue Apr 25, 2024 · 2 comments · Fixed by #3348 · May be fixed by #3440
Open

Support knob to configure consistent hash table size #3272

aoledk opened this issue Apr 25, 2024 · 2 comments · Fixed by #3348 · May be fixed by #3440
Assignees
@aoledk
Labels
area/api API-related issues
Milestone
v1.1.0-rc1

Comments

@aoledk
Copy link
Contributor

aoledk commented Apr 25, 2024 •
edited

Description:

Backend whose LoadBalancer type is ConsistentHash will be translated to xDS cluster whose type is Maglev, but we can't configure maglev table size which is very important in long lived TCP load balancing use case. Bigger size, smaller disruption.

[optional Relevant Links:]

https://gateway.envoyproxy.io/v1.0.1/api/extension_types/#consistenthash
https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/cluster/v3/cluster.proto#config-cluster-v3-cluster-maglevlbconfig
@aoledk aoledk added the triage label Apr 25, 2024
@aoledk aoledk mentioned this issue May 8, 2024
Merged
@aoledk
Copy link
Contributor Author

aoledk commented May 8, 2024

/assign

@shawnh2 shawnh2 added area/api API-related issues and removed triage labels May 8, 2024
@shawnh2
Copy link
Contributor

shawnh2 commented May 15, 2024

reopen this since #3348 only implements api

@shawnh2 shawnh2 reopened this May 15, 2024
@arkodg arkodg added this to the v1.1.0-rc1 milestone May 15, 2024
@aoledk aoledk linked a pull request May 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aoledk aoledk

Labels
area/api API-related issues
Projects
None yet
Milestone
v1.1.0-rc1
3 participants
@aoledk @arkodg @shawnh2