Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a knob to make per_connection_buffer_limit_bytes of cluster configurable #3278

Open
aoledk opened this issue Apr 26, 2024 · 5 comments · May be fixed by #3479
Open

Add a knob to make per_connection_buffer_limit_bytes of cluster configurable #3278

aoledk opened this issue Apr 26, 2024 · 5 comments · May be fixed by #3479
Assignees
Labels
area/api API-related issues
Milestone

Comments

@aoledk
Copy link
Contributor

aoledk commented Apr 26, 2024

Description:

EG can configure per_connection_buffer_limit_bytes on xDS Listener currently via #2600, not available to configure per_connection_buffer_limit_bytes on xDS Cluster, default to 32KB. A new knob will be better for entire buffer sizing control of Envoy provisioned by EG.

[optional Relevant Links:]

https://gateway.envoyproxy.io/latest/api/extension_types/#connection
https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/cluster/v3/cluster.proto#config-cluster-v3-cluster

@aoledk aoledk added the triage label Apr 26, 2024
@shawnh2 shawnh2 added help wanted Extra attention is needed area/api API-related issues and removed triage labels Apr 26, 2024
@ShyunnY
Copy link
Contributor

ShyunnY commented Apr 27, 2024

hey, @aoledk
Do you have any ideas or are you currently working on this PR?

@aoledk
Copy link
Contributor Author

aoledk commented Apr 29, 2024

hey, @aoledk Do you have any ideas or are you currently working on this PR?

@ShyunnY Perhaps this feature should be implemented via BackendTrafficPolicy, similar way like https://gateway.envoyproxy.io/latest/api/extension_types/#connection works. And I'm not working on this Issue.

@ShyunnY
Copy link
Contributor

ShyunnY commented Apr 29, 2024

/assign

@guydc
Copy link
Contributor

guydc commented Apr 29, 2024

+1 in general. @aoledk - can you maybe describe the scenario where this is needed?

@aoledk
Copy link
Contributor Author

aoledk commented Apr 30, 2024

@guydc When EG is used as L4 proxy and serves massive long lived TCP connection, the buffer size of <Downstream, Envoy> and <Envoy, Upstream> connections should be controlled, to reduce memory consumption of Envoy.

@shawnh2 shawnh2 removed the help wanted Extra attention is needed label May 14, 2024
@arkodg arkodg added this to the v1.1.0-rc1 milestone May 21, 2024
@ShyunnY ShyunnY linked a pull request May 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api API-related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants