Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to new Go protobuf v2 module #524

Open
jpeach opened this issue Dec 13, 2021 · 10 comments
Open

Switch to new Go protobuf v2 module #524

jpeach opened this issue Dec 13, 2021 · 10 comments
Assignees
@jpeach @alecholmez @sunjayBhatia
Labels
no stalebot

Comments

@jpeach
Copy link
Contributor

jpeach commented Dec 13, 2021

Upstream switched to a new Go protobuf module, protobuf v2. go-control-plane should fully switch over to this so that client projects can switch too. I think the main change that will be needed is to switch the protoc toolchain over to generate wrapper code with the new module.
@jpeach jpeach mentioned this issue Dec 13, 2021
Open
@alecholmez
Copy link
Contributor

alecholmez commented Dec 14, 2021 •
edited

+1 for this. We looked into this previously and I believe the action items were:

Here's an issue for reference: #403

I can try and help out with this @jpeach but I'm not super skilled/familiar with bazel. I can stumble my way around if you do need me to tackle something though

@jpeach
Copy link
Contributor Author

jpeach commented Dec 14, 2021 •
edited

Oof, that does not look promising ...

@alecholmez
Copy link
Contributor

Oof, that does not look promising ...

Yea... this is a big rabbit hole I went down a while back, might be worth revisiting though

@github-actions
Copy link

github-actions bot commented Feb 6, 2022

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 6, 2022
@arnehormann
Copy link

This should be fixed with rules_go v0.33.0: bazelbuild/rules_go#2522 (comment)

@alecholmez
Copy link
Contributor

I have a PR open for this now: envoyproxy/envoy#21790

@alecholmez
Copy link
Contributor

alecholmez commented Jun 21, 2022 •
edited

Okay looks like this pr: envoyproxy/envoy#21790 got merged so we can now proceed here. @jpeach would you be interested in picking this back up?

@jpeach
Copy link
Contributor Author

jpeach commented Jun 23, 2022

Okay looks like this pr: envoyproxy/envoy#21790 got merged so we can now proceed here. @jpeach would you be interested in picking this back up?

I can probably take a look in a week or so.

@yckbilly1929
Copy link

#607

Would like to know if we will resolve this issue together with this PR?

@github-actions github-actions bot removed the stale label Dec 19, 2022
@jpeach jpeach mentioned this issue Jun 5, 2023
Closed
jpeach added a commit to jpeach/go-control-plane that referenced this issue Nov 19, 2023
@jpeach
Use the v2 protobuf module internally.
7df4839 
There's only one place where we use the protobug APIs, so switch
to the v2 protobuf module.

This updates envoyproxy#524.

Signed-off-by: James Peach <jpeach@apache.org>
jpeach added a commit to jpeach/go-control-plane that referenced this issue Nov 19, 2023
@jpeach
Use the v2 protobuf module internally.
ccadde9 
There's only one place where we use the protobuf APIs, so switch
to the v2 protobuf module.

This updates envoyproxy#524.

Signed-off-by: James Peach <jpeach@apache.org>
@jpeach jpeach mentioned this issue Nov 19, 2023
Merged
jpeach added a commit that referenced this issue Nov 20, 2023
@jpeach
Use the v2 protobuf module internally. (#819)
a47957f 
There's only one place where we use the protobuf APIs, so switch
to the v2 protobuf module.

This updates #524.

Signed-off-by: James Peach <jpeach@apache.org>
@mmorel-35
Copy link
Contributor

mmorel-35 commented Mar 27, 2024 •
edited

@jpeach

Fixed by db0b36a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpeach jpeach

@alecholmez alecholmez

@sunjayBhatia sunjayBhatia

Labels
no stalebot
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jpeach @arnehormann @alecholmez @sunjayBhatia @mmorel-35 @yckbilly1929