Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xds API v2 deprecation #154

Open
nezdolik opened this issue Nov 23, 2020 · 1 comment
Open

Xds API v2 deprecation #154

nezdolik opened this issue Nov 23, 2020 · 1 comment

Comments

@nezdolik
Copy link
Member

nezdolik commented Nov 23, 2020 •
edited

Xds api v2 has been "softly" deprecated in latest Envoy release. Our integration tests fail with errors like:

gRPC config for type.googleapis.com/envoy.api.v2.Listener rejected: The v2 xDS major version is deprecated and disabled by default. Support for v2 will be removed from Envoy at the start of Q1 2021. You may make use of v2 in Q3 2020 by setting '--bootstrap-version 2' on the CLI for a v2 bootstrap file and also enabling the runtime envoy.reloadable_features.enable_deprecated_v2_api flag. (envoy.api.v2.Listener)
[tc-okhttp-stream-439430225] INFO 🐳 [envoyproxy/envoy-alpine-dev:latest] - STDERR:

Short term fix would be to add -bootstrap-version 2 to Envoy container used in tests, long term to get rid of all v2 tests/code. This blocks all incoming PRs.
@slonka slonka mentioned this issue Dec 4, 2020
Merged
@slonka
Copy link
Member

slonka commented Dec 11, 2020

Tests have been fixed, we will be deprecating v2 when we fix the release issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slonka @nezdolik