Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MessageOptions in validate.proto uses a reserved extension number #296

Open
jasonfagerberg-toast opened this issue Oct 6, 2023 · 0 comments
Open

MessageOptions in validate.proto uses a reserved extension number #296

jasonfagerberg-toast opened this issue Oct 6, 2023 · 0 comments

Comments

@jasonfagerberg-toast
Copy link

The Java control plane validate proto is using extension number 1072.

This extension number is reserved for protokt and causes incompatibilities between the envoy proto and protokt

This MessageOption should be implemented as a message like it is in validate.proto's FieldOptions to prevent this issue
@andrewparmet andrewparmet mentioned this issue Dec 24, 2023
Merged
andrewparmet added a commit to bufbuild/buf-gradle-plugin that referenced this issue Jan 2, 2024
@andrewparmet
Add test codifying behavior when two modules reuse the same extension…
7fc4efd 
… number (#171)

Beginning the process of addressing
envoyproxy/java-control-plane#296.

The plugin should be able to be configured to ignore these conflicts
since the user is not in control of the bad actor dependency.

The failing tests are due to user-level failure, but in principle (and
this is what happened) one may have dependencies that conflict and
there's nothing you can do.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jasonfagerberg-toast