Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicated opentelemetry packages #342

Open
joybestourous opened this issue Mar 8, 2024 · 0 comments
Open

duplicated opentelemetry packages #342

joybestourous opened this issue Mar 8, 2024 · 0 comments

Comments

@joybestourous
Copy link

Problem
It looks like java-control-plane replicates opentelemetry-proto-java without relocating the dependencies (i.e. you folks use the same package and class names). This duplicates the classes such that now that we've added the io.envoyproxy.controlplane dependency to a core library, maven's dependency:analyze tool is forcing us to import io.envoyproxy.controlplane in modules that do not interact with controlplane code at all. In a few places, we were forced to replace the opentelemetry import with envoyproxy.controlplane. Our (pruned) jdeps output reveals this issue:

jdeps -verbose --class-path ~/.m2/repository/io/envoyproxy/controlplane/api/1.0.41/api-1.0.41.jar  path/to/now_requires_controlplane_import.jar | grep 'api-1.0.41.jar'

now_requires_controlplane_import.jar -> /Users/joy.bestourous/.m2/repository/io/envoyproxy/controlplane/api/1.0.41/api-1.0.41.jar
<FILE IN JAR> -> io.opentelemetry.proto.common.v1.AnyValue          api-1.0.41.jar
...

Solution Requested
We're hoping you folks could either depend directly on opentelemetry-proto or use a different package to avoid this duplication and subsequent maven confusion.

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant