Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support request trailers in the test server #1103

Open
eric846 opened this issue Mar 19, 2024 · 0 comments
Open

support request trailers in the test server #1103

eric846 opened this issue Mar 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@eric846
Copy link
Contributor

eric846 commented Mar 19, 2024

Based on looking at the code, my guess is that the test server doesn't respond when the request has trailers. I haven't tried it though.

We only do sendReply() when end_stream is true in decodeHeaders or decodeBody:
https://github.com/envoyproxy/nighthawk/blob/main/source/server/http_test_server_filter.cc

If the request has trailers, my guess is is:

  • end_stream won't be true in decodeHeaders
  • end_stream won't be true in decodeBody
  • end_stream will be true in decodeTrailers, but it doesn't send a reply

The integration test fixture we're using doesn't appear to support adding request trailers.

@eric846 eric846 added the enhancement New feature or request label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant