Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client side access logging #780

Open
howardjohn opened this issue Dec 4, 2021 · 4 comments
Open

Client side access logging #780

howardjohn opened this issue Dec 4, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@howardjohn
Copy link

Title: Client side access logging

Description:
It would be nice to be able to output standard Envoy access logs from the client. This would allow fine grained analysis of request patterns, rather than aggregations. This allows monitoring things like traffic trends (ex: a spike of latency every 30s from cronjob on the same host, decaying latency due to thermal throttling, etc).

[optional Relevant Links:]

Any extra documentation required to understand the issue.

@howardjohn howardjohn added the enhancement New feature or request label Dec 4, 2021
@mum4k
Copy link
Collaborator

mum4k commented Dec 4, 2021

Thank you for starting this conversation @howardjohn, for completeness, could you provide a reference to what is meant by standard Envoy access logs, i.e. a link t the relevant portion of the Envoy documentation or maybe even an example?

@howardjohn
Copy link
Author

howardjohn commented Dec 5, 2021 via email

@howardjohn
Copy link
Author

Example of how this is useful: fortio/fortio#498. A similar feature in Fortio (or really my not-yet-merged fork of fortio) was able to find suboptimal traffic patterns that existing metric aggregations miss.

One concern is in Envoy the access log config is in listener rather than cluster. Although I did notice that there is an AccessLogManager input to cluster so maybe it would work.

@mum4k
Copy link
Collaborator

mum4k commented Dec 9, 2021

Thank you @howardjohn, adding the ability to enable the logging shouldn't be too hard and would be useful when analyzing performance patterns. There might be an impact on Nighthawk's ability to generate load (it might slow it down), but that would only happen when this is enabled and we can cross that bridge once we get there.

Please let me know if you would be interested in contributing this feature, in which case we can get together and design it. Alternatively we can mark this request as help needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants