Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish extracting time-tracking and dynamic-delay filters from ResponseOptions proto #859

Open
dubious90 opened this issue Jun 6, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@dubious90
Copy link
Contributor

After #855 is pushed through, these two filters now have their own configuration for starting up the filters, without any internal references to ResponseOptions.proto. However, the header override api still requires their fields to exist on ResponseOptions.proto, because the ResponseOptions proto is what is passed through the x-nighthawk-test-server-config header.

In order to move off this, we should:

  1. Introduce three separate headers, one for each configuration (or one new header with three subsets of configuration). The current header will then become a legacy header and will issue warnings
  2. Introduce a flag that makes only the new headers work
  3. Remove the old header completely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant