Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using deprecated mock method macros #914

Open
dubious90 opened this issue Sep 21, 2022 · 0 comments
Open

Stop using deprecated mock method macros #914

dubious90 opened this issue Sep 21, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers tech-debt

Comments

@dubious90
Copy link
Contributor

When running fix_format, it will give a complaint like the following:

ERROR: From ./../nbperry-nighthawk/test/test_common/mock_stream.h
ERROR: ./../nbperry-nighthawk/test/test_common/mock_stream.h:15: The MOCK_METHODn() macros should not be used, use MOCK_METHOD() instead
ERROR: ./../nbperry-nighthawk/test/test_common/mock_stream.h:18: The MOCK_METHODn() macros should not be used, use MOCK_METHOD() instead
ERROR: ./../nbperry-nighthawk/test/test_common/mock_stream.h:21: The MOCK_METHODn() macros should not be used, use MOCK_METHOD() instead
ERROR: ./../nbperry-nighthawk/test/test_common/mock_stream.h:31: The MOCK_METHODn() macros should not be used, use MOCK_METHOD() instead
ERROR: ./../nbperry-nighthawk/test/test_common/mock_stream.h:34: The MOCK_METHODn() macros should not be used, use MOCK_METHOD() instead
ERROR: ./../nbperry-nighthawk/test/test_common/mock_stream.h:35: The MOCK_METHODn() macros should not be used, use MOCK_METHOD() instead
ERROR: ./../nbperry-nighthawk/test/test_common/mock_stream.h:38: The MOCK_METHODn() macros should not be used, use MOCK_METHOD() instead
ERROR: ./../nbperry-nighthawk/test/test_common/mock_stream.h:41: The MOCK_METHODn() macros should not be used, use MOCK_METHOD() instead
ERROR: ./../nbperry-nighthawk/test/test_common/mock_stream.h:42: The MOCK_METHODn() macros should not be used, use MOCK_METHOD() instead

I considered this outside the scope of fixing formatting, but as a followup we should probably move to MOCK_METHOD.
@dubious90 dubious90 added enhancement New feature or request good first issue Good for newcomers tech-debt labels Sep 21, 2022
@dubious90 dubious90 mentioned this issue Sep 21, 2022
Merged
dubious90 pushed a commit that referenced this issue Sep 23, 2022
Make the fix_format and check_format scripts work on Nighthawk code (#…
73a7bf6 
…916)

Fixes #913

Direct changes:
- Modified config.yaml to not exclude the current directory, which was excluding all of NH
- Overrode some settings in config.yaml to move past some code changes
    - Filed #914 and #915 to address these overrides in the future
- Moved include_dir_order from check_format.sh over to the config.yaml where it now needs to live.

Also ran the format script to fix all current code formatting errors.

Signed-off-by: Nathan Perry <nbperry@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers tech-debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dubious90