build: make it build with bazelisk --strict
#327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
|
This looks fine, but I think we need to wait for: #328 to be merged, so CI can work and we can validate it doesn't break anything (although testing locally it doesn't seem to). |
|
Thanks for merging in master. It looks like the build is still failing because the well-known proto types (duration, etc.) can't be found. |
|
@akonradi I have to fix |
akonradi
suggested changes
Apr 1, 2020
akonradi
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For envoyproxy/envoy#9490 envoyproxy/envoy#9489 envoyproxy/envoy#9488
Signed-off-by: Lizan Zhou lizan@tetrate.io