Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v7.1.2 is not working on IE #329

Open
ysgk opened this issue Dec 18, 2019 · 2 comments · May be fixed by #330
Open

v7.1.2 is not working on IE #329

ysgk opened this issue Dec 18, 2019 · 2 comments · May be fixed by #330
Labels
Good first PR Help wanted V - PATCH Version Control

Comments

@ysgk
Copy link

ysgk commented Dec 18, 2019

Hi,

I'm using jasmine-enzyme to test components on real browsers using karma according to this guide.
However, I noticed that IE tests are failing since v7.1.2.
This is because the current babel target is node: 'current'.
Could that be more widened so that IE tests run without compiling enzyme-matchers?
@blainekasten
Copy link
Collaborator

@ysgk Oooo, good point. I typically live in jest land and completely forgot about running in browsers.. Yeah we should fix this. Mind submitting a PR?

@ysgk ysgk linked a pull request Dec 20, 2019 that will close this issue
Open
@ysgk
Copy link
Author

ysgk commented Dec 20, 2019

@blainekasten
Thanks for the quick response :) I submitted #330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first PR Help wanted V - PATCH Version Control
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix babel target to es5 ysgk/enzyme-matchers
2 participants
@blainekasten @ysgk