Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status of the project #353

Open
scinos opened this issue Mar 10, 2021 · 13 comments
Open

Status of the project #353

scinos opened this issue Mar 10, 2021 · 13 comments

Comments

@scinos
Copy link

scinos commented Mar 10, 2021

Hi!

What is the status of this project? Is it still being maintained?

Last commit is from almost 1 year ago, and since then there has been important issues like Node 14 support (#349) or Jest 26 support (#351) with no comment from the maintainers.
@ljharb
Copy link
Member

ljharb commented Mar 10, 2021

The project was recently moved into the enzyme org; I'll try to address those issues and cut a release in the next few weeks.

@scinos
Copy link
Author

scinos commented Mar 10, 2021

Awesome, thanks for the response! Please let us know if there is something you need help with, maybe I can help.

@Kikobeats
Copy link

looks like this project is dead ☹️

@ljharb
Copy link
Member

ljharb commented Jun 5, 2021

@Kikobeats its very much not dead; i just haven’t had time yet to get to it.

@scinos
Copy link
Author

scinos commented Jun 5, 2021 via email •
edited

@Kikobeats
Copy link

@ljharb if you give us the right permissions, we can push the project forward!

There are some easy PR that can be merged and keep the project up to date.

@AlonMiz
Copy link

AlonMiz commented Jul 1, 2021

agree. we are stuck right now because of the out of dated js dom.
that isn't working with react 17.
also in order for something to work, we needed this package
@wojtekmaj/enzyme-adapter-react-17

@mcmire mcmire mentioned this issue Sep 1, 2021
Merged
@LexaDel
Copy link

LexaDel commented Sep 27, 2021

@ljharb Hi, Could you update jest-environment-jsdom in jest-environment-enzyme to 27.2.2 version to support the new jest?

@ljharb
Copy link
Member

ljharb commented Sep 27, 2021

@LexaDel it's on my list of stuff to do.

@BerkeleyTrue

This comment has been minimized.

Sign in to view
@GoudekettingRM
Copy link

@ljharb Thanks for doing this! Can imagine how much work it would be. Do you have a timeline for react 17 and node support?

@ljharb
Copy link
Member

ljharb commented Nov 16, 2021

I do not have a timeline for react 17 support; i don’t know what “node support” it’s lacking.

@GoudekettingRM

This comment has been minimized.

Sign in to view
anomiex added a commit to Automattic/jetpack that referenced this issue Dec 3, 2021
@anomiex
Cleanup pnpm overrides
841ea55 
* Pnpm has started wanting to update `@storybook/builder-webpack5`
  with every upstream release. Giving the relevant overrides a version
  makes it stick with the lockfile.
* `@automattic/format-currency` seems a bit outdated. We can clean up a
  lot of the old deps we have in pnpm-lock.yaml by updating its dep on
  `i18n-calypso` from 4.x to 5.x, and in turn updating `i18n-calypso`'s
  dep on `interpolate-components` 1.1.0 too.
* `jest-environment-enzyme` is [supposedly not dead][1], but still isn't
  being updated for several months. For our purposes at least it seems
  to work fine with jest-environment-jsdom 27.
* Looks like we've dropped the dep on whatever old version of
  `terser-webpack-plugin` had a dep on an old version of
  `serialize-javascript`, so drop the override.

[1]: enzymejs/enzyme-matchers#353
@anomiex anomiex mentioned this issue Dec 3, 2021
Merged
anomiex added a commit to Automattic/jetpack that referenced this issue Dec 6, 2021
@anomiex
Cleanup pnpm overrides (#21944)
ea2ffbb 
* Pnpm has started wanting to update `@storybook/builder-webpack5`
  with every upstream release. Giving the relevant overrides a version
  makes it stick with the lockfile.
* `@automattic/format-currency` seems a bit outdated. We can clean up a
  lot of the old deps we have in pnpm-lock.yaml by updating its dep on
  `i18n-calypso` from 4.x to 5.x, and in turn updating `i18n-calypso`'s
  dep on `interpolate-components` 1.1.0 too.
* `jest-environment-enzyme` is [supposedly not dead][1], but still isn't
  being updated for several months. For our purposes at least it seems
  to work fine with jest-environment-jsdom 27.
* Looks like we've dropped the dep on whatever old version of
  `terser-webpack-plugin` had a dep on an old version of
  `serialize-javascript`, so drop the override.

[1]: enzymejs/enzyme-matchers#353
matticbot pushed a commit to Automattic/jetpack-storybook that referenced this issue Dec 6, 2021
@anomiex @matticbot
Cleanup pnpm overrides (#21944)
4cc3884 
* Pnpm has started wanting to update `@storybook/builder-webpack5`
  with every upstream release. Giving the relevant overrides a version
  makes it stick with the lockfile.
* `@automattic/format-currency` seems a bit outdated. We can clean up a
  lot of the old deps we have in pnpm-lock.yaml by updating its dep on
  `i18n-calypso` from 4.x to 5.x, and in turn updating `i18n-calypso`'s
  dep on `interpolate-components` 1.1.0 too.
* `jest-environment-enzyme` is [supposedly not dead][1], but still isn't
  being updated for several months. For our purposes at least it seems
  to work fine with jest-environment-jsdom 27.
* Looks like we've dropped the dep on whatever old version of
  `terser-webpack-plugin` had a dep on an old version of
  `serialize-javascript`, so drop the override.

[1]: enzymejs/enzyme-matchers#353

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/1546542590
matticbot pushed a commit to Automattic/jetpack-connection-ui that referenced this issue Dec 6, 2021
@anomiex @matticbot
Cleanup pnpm overrides (#21944)
4322189 
* Pnpm has started wanting to update `@storybook/builder-webpack5`
  with every upstream release. Giving the relevant overrides a version
  makes it stick with the lockfile.
* `@automattic/format-currency` seems a bit outdated. We can clean up a
  lot of the old deps we have in pnpm-lock.yaml by updating its dep on
  `i18n-calypso` from 4.x to 5.x, and in turn updating `i18n-calypso`'s
  dep on `interpolate-components` 1.1.0 too.
* `jest-environment-enzyme` is [supposedly not dead][1], but still isn't
  being updated for several months. For our purposes at least it seems
  to work fine with jest-environment-jsdom 27.
* Looks like we've dropped the dep on whatever old version of
  `terser-webpack-plugin` had a dep on an old version of
  `serialize-javascript`, so drop the override.

[1]: enzymejs/enzyme-matchers#353

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/1546542590
matticbot pushed a commit to Automattic/jetpack-backup-plugin that referenced this issue Dec 6, 2021
@anomiex @matticbot
Cleanup pnpm overrides (#21944)
a050c76 
* Pnpm has started wanting to update `@storybook/builder-webpack5`
  with every upstream release. Giving the relevant overrides a version
  makes it stick with the lockfile.
* `@automattic/format-currency` seems a bit outdated. We can clean up a
  lot of the old deps we have in pnpm-lock.yaml by updating its dep on
  `i18n-calypso` from 4.x to 5.x, and in turn updating `i18n-calypso`'s
  dep on `interpolate-components` 1.1.0 too.
* `jest-environment-enzyme` is [supposedly not dead][1], but still isn't
  being updated for several months. For our purposes at least it seems
  to work fine with jest-environment-jsdom 27.
* Looks like we've dropped the dep on whatever old version of
  `terser-webpack-plugin` had a dep on an old version of
  `serialize-javascript`, so drop the override.

[1]: enzymejs/enzyme-matchers#353

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/1546542590
matticbot pushed a commit to Automattic/jetpack-production that referenced this issue Dec 6, 2021
@anomiex @matticbot
Cleanup pnpm overrides (#21944)
c054994 
* Pnpm has started wanting to update `@storybook/builder-webpack5`
  with every upstream release. Giving the relevant overrides a version
  makes it stick with the lockfile.
* `@automattic/format-currency` seems a bit outdated. We can clean up a
  lot of the old deps we have in pnpm-lock.yaml by updating its dep on
  `i18n-calypso` from 4.x to 5.x, and in turn updating `i18n-calypso`'s
  dep on `interpolate-components` 1.1.0 too.
* `jest-environment-enzyme` is [supposedly not dead][1], but still isn't
  being updated for several months. For our purposes at least it seems
  to work fine with jest-environment-jsdom 27.
* Looks like we've dropped the dep on whatever old version of
  `terser-webpack-plugin` had a dep on an old version of
  `serialize-javascript`, so drop the override.

[1]: enzymejs/enzyme-matchers#353

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/1546542590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@ljharb @scinos @AlonMiz @Kikobeats @BerkeleyTrue @LexaDel @GoudekettingRM