From 552714eed072a6a4d64c02ce8b6e588a59e0ff36 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=99=B3=E4=B9=99=E5=B1=B1?= Date: Thu, 28 Feb 2019 18:00:32 +0800 Subject: [PATCH] Fix old gDSFP test of shallowWrapper --- packages/enzyme-test-suite/test/ShallowWrapper-spec.jsx | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/packages/enzyme-test-suite/test/ShallowWrapper-spec.jsx b/packages/enzyme-test-suite/test/ShallowWrapper-spec.jsx index 2e2b86dd6..666322845 100644 --- a/packages/enzyme-test-suite/test/ShallowWrapper-spec.jsx +++ b/packages/enzyme-test-suite/test/ShallowWrapper-spec.jsx @@ -6011,7 +6011,14 @@ describe('shallow', () => { prevContext, nextContext, }; + // In shallow wrapper we try to fix a React shallow renderer bug (facebook/react#14607, fixed in react 16.8). + // so we have to call gDSFP before shallow renderer rendering to set correct instance state in sCU + // which will cause gDSFP called twice in this tests expect(spy.args).to.deep.equal([ + ['getDerivedStateFromProps', { + props: nextProps, + state: nextState, + }], ['getDerivedStateFromProps', { props: nextProps, state: nextState,