[Fix] debug: inspect objects instead of showing them as `<Component…

… />`
enzymejs · Aug 28, 2018 · a7b6e78 · a7b6e78
1 parent 2c775b4
commit a7b6e78
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/packages/enzyme-test-suite/test/Debug-spec.jsx b/packages/enzyme-test-suite/test/Debug-spec.jsx
@@ -813,14 +813,16 @@ describe('debug', () => {
     it('handles function children', () => {
       class Abomination extends React.Component {
         render() {
-          /* eslint no-unused-vars: 0, func-names: 0 */
+          /* eslint no-unused-vars: 0, func-names: 0, react/no-children-prop: 0 */
           return (
             <div>
               {function Foo() { /* hi */ }}
               {<span />}
               {arrow => arrow('function')}
               {[1, 2, NaN]}
               {function (anonymous) {}}
+              {{ a: 'b' }}
+              <span children={{ c: 'd' }} />
             </div>
           );
         }
@@ -836,6 +838,10 @@ describe('debug', () => {
   2
   NaN
   [function]
+  {{ a: 'b' }}
+  <span>
+    {{ c: 'd' }}
+  </span>
 </div>`
       ));
     });

diff --git a/packages/enzyme/src/Debug.js b/packages/enzyme/src/Debug.js
@@ -5,6 +5,7 @@ import isNumber from 'is-number-object';
 import isCallable from 'is-callable';
 import isBoolean from 'is-boolean-object';
 import inspect from 'object-inspect';
+import has from 'has';
 
 import {
   propsOfNode,
@@ -67,6 +68,16 @@ function indentChildren(childrenStrs, indentLength) {
     : '';
 }
 
+function isRSTNodeLike(node) {
+  return has(node, 'nodeType')
+    && typeof node.nodeType === 'string'
+    && has(node, 'type')
+    && has(node, 'key')
+    && has(node, 'ref')
+    && has(node, 'instance')
+    && has(node, 'rendered');
+}
+
 export function debugNode(node, indentLength = 2, options = {}) {
   if (typeof node === 'string' || typeof node === 'number') return escape(node);
   if (typeof node === 'function') {
@@ -75,6 +86,11 @@ export function debugNode(node, indentLength = 2, options = {}) {
   }
   if (!node) return '';
 
+  const adapter = getAdapter();
+  if (!adapter.isValidElement(node) && !isRSTNodeLike(node)) {
+    return `{${inspect(node)}}`;
+  }
+
   const childrenStrs = childrenOfNode(node)
     .map(n => debugNode(n, indentLength, options))
     .filter(Boolean);