From e60788c2068df31e245a5d5b52e61cf4589cf8e6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=99=B3=E4=B9=99=E5=B1=B1?= Date: Sun, 21 Apr 2019 14:19:01 +0800 Subject: [PATCH] Import fakeDynamicImport from enzyme-adapter-utils Change the import from `enzyme-test-utils/src/Utils` to `enzyme-test-utils`. The test results are same in both way. But the coverage is broken when we import from `enzyme-test-utils/src/Utils`. I'm not sure why but maybe this breaks the tested lines / branch computation in nyc. --- packages/enzyme-test-suite/test/Adapter-spec.jsx | 3 +-- packages/enzyme-test-suite/test/ShallowWrapper-spec.jsx | 2 +- .../enzyme-test-suite/test/_helpers/getLoadedLazyComponent.js | 2 +- packages/enzyme-test-suite/test/staticRender-spec.jsx | 2 +- 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/packages/enzyme-test-suite/test/Adapter-spec.jsx b/packages/enzyme-test-suite/test/Adapter-spec.jsx index 9cd16ac76..016d2505c 100644 --- a/packages/enzyme-test-suite/test/Adapter-spec.jsx +++ b/packages/enzyme-test-suite/test/Adapter-spec.jsx @@ -9,8 +9,7 @@ import { } from 'react-is'; import PropTypes from 'prop-types'; import wrap from 'mocha-wrap'; -import { wrapWithWrappingComponent, RootFinder } from 'enzyme-adapter-utils'; -import { fakeDynamicImport } from 'enzyme-adapter-utils/src/Utils'; +import { fakeDynamicImport, wrapWithWrappingComponent, RootFinder } from 'enzyme-adapter-utils'; import './_helpers/setupAdapters'; import Adapter from './_helpers/adapter'; diff --git a/packages/enzyme-test-suite/test/ShallowWrapper-spec.jsx b/packages/enzyme-test-suite/test/ShallowWrapper-spec.jsx index 7b6860b5a..7c58d2025 100644 --- a/packages/enzyme-test-suite/test/ShallowWrapper-spec.jsx +++ b/packages/enzyme-test-suite/test/ShallowWrapper-spec.jsx @@ -14,7 +14,7 @@ import { withSetStateAllowed, } from 'enzyme/build/Utils'; import getAdapter from 'enzyme/build/getAdapter'; -import { fakeDynamicImport } from 'enzyme-adapter-utils/src/Utils'; +import { fakeDynamicImport } from 'enzyme-adapter-utils'; import './_helpers/setupAdapters'; import { diff --git a/packages/enzyme-test-suite/test/_helpers/getLoadedLazyComponent.js b/packages/enzyme-test-suite/test/_helpers/getLoadedLazyComponent.js index 075912c3b..d9ca7765e 100644 --- a/packages/enzyme-test-suite/test/_helpers/getLoadedLazyComponent.js +++ b/packages/enzyme-test-suite/test/_helpers/getLoadedLazyComponent.js @@ -1,4 +1,4 @@ -import { fakeDynamicImport } from 'enzyme-adapter-utils/src/Utils'; +import { fakeDynamicImport } from 'enzyme-adapter-utils'; import { lazy } from './react-compat'; import { is, VERSION } from './version'; diff --git a/packages/enzyme-test-suite/test/staticRender-spec.jsx b/packages/enzyme-test-suite/test/staticRender-spec.jsx index 9d28d09fd..e130c1352 100644 --- a/packages/enzyme-test-suite/test/staticRender-spec.jsx +++ b/packages/enzyme-test-suite/test/staticRender-spec.jsx @@ -3,7 +3,7 @@ import PropTypes from 'prop-types'; import { expect } from 'chai'; import { render } from 'enzyme'; import renderEntry from 'enzyme/render'; -import { fakeDynamicImport } from 'enzyme-adapter-utils/src/Utils'; +import { fakeDynamicImport } from 'enzyme-adapter-utils'; import './_helpers/setupAdapters'; import { describeWithDOM, describeIf } from './_helpers';