Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete React 16 support #1553

Open
27 of 41 tasks
ljharb opened this issue Mar 2, 2018 · 36 comments
Open
27 of 41 tasks

Complete React 16 support #1553

ljharb opened this issue Mar 2, 2018 · 36 comments

Comments

@ljharb
Copy link
Member

ljharb commented Mar 2, 2018

Overarching project: https://github.com/airbnb/enzyme/projects/4

@MarcoNicolodi
Copy link

Isnt #1229 related to this?

@ljharb
Copy link
Member Author

ljharb commented Mar 13, 2018

@MarcoNicolodi I don't think it is; that issue might either be a bug in v3 or intended behavior, but it's not related to React 16 specifically.

@petegleeson
Copy link

@ljharb I have verified that #1592 solves the forwardRef problem.

What is the release plan for these fixes? New versions for each feature or one release when all of these are completed?

Please let me know if there is anything I can do to help out.

jtanner added a commit to mxenabled/mx-react-components that referenced this issue Apr 9, 2018
jtanner added a commit to mxenabled/mx-react-components that referenced this issue Apr 11, 2018
@ljharb
Copy link
Member Author

ljharb commented Apr 12, 2018

I’m hoping to bunch together as many as possible; there’s currently a backlog for me to go through, after which i hope to cut a release.

@ghost
Copy link

ghost commented Apr 16, 2018

@ljharb is there a list of issues you'd like to get merged before releasing a new version on npm? Would love to see this one get released soon: #1513 as my team has already migrated our codebase so just waiting on tests passing.

Perhaps we could help finish up some issues for you to get the release in.

@simonbuchan
Copy link

simonbuchan commented May 2, 2018

Nope, just #1504 - createRef() works fine when it's nested. What about createRef()? I'm hitting that not working in styled-components/styled-components#1720 - even with just pure react + enzyme. Here's the test copied over:

test('enzyme should mount object refs', () => {
  const ref = React.createRef()
  const wrapper = mount(<div ref={ref} />)
  const div = wrapper.find('div').first()
  expect(div).toBeTruthy()
  expect(ref).toHaveProperty('current', div.instance())
})

Is this just a dumb mistake I'm making?

@nemoDreamer
Copy link

Is there any chance of an alpha release, or do all features need to be supported in one go?

@eps1lon eps1lon mentioned this issue Mar 17, 2019
13 tasks
@holsted
Copy link

holsted commented Sep 5, 2019

It looks like the Profiler tickbox is still unsupported but the linked issue is closed. Are there plans to add support for this?

I ended up opening a PR for this.

@jimmywongroo

This comment has been minimized.

@ljharb

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment