From 45aab30e4718adf547a04d2f4019ee8258716f39 Mon Sep 17 00:00:00 2001
From: Ed Page <eopage@gmail.com>
Date: Tue, 26 Jul 2022 10:38:59 -0500
Subject: [PATCH] WIP: fix!: Make Set the default action

Fixes #2687
---
 src/builder/arg.rs          | 3 ---
 src/builder/arg_settings.rs | 2 +-
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/builder/arg.rs b/src/builder/arg.rs
index e9d13a2241b..0e07d20619d 100644
--- a/src/builder/arg.rs
+++ b/src/builder/arg.rs
@@ -4269,9 +4269,6 @@ impl<'help> Arg<'help> {
 /// # Internally used only
 impl<'help> Arg<'help> {
     pub(crate) fn _build(&mut self) {
-        if self.is_positional() {
-            self.settings.set(ArgSettings::TakesValue);
-        }
         if self.action.is_none() {
             if self.get_id() == "help" && !self.is_takes_value_set() {
                 let action = super::ArgAction::Help;
diff --git a/src/builder/arg_settings.rs b/src/builder/arg_settings.rs
index 87dccd2d845..6deaf50d9af 100644
--- a/src/builder/arg_settings.rs
+++ b/src/builder/arg_settings.rs
@@ -14,7 +14,7 @@ pub(crate) struct ArgFlags(Flags);
 
 impl Default for ArgFlags {
     fn default() -> Self {
-        Self::empty()
+        ArgFlags(Flags::TAKES_VAL)
     }
 }