Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade application to React 18 #513

Open
NataliaDSmirnova opened this issue Feb 19, 2024 · 1 comment
Open

Upgrade application to React 18 #513

NataliaDSmirnova opened this issue Feb 19, 2024 · 1 comment
Assignees
Labels
dependencies Pull requests that update a dependency file miew-app

Comments

@NataliaDSmirnova
Copy link
Collaborator

NataliaDSmirnova commented Feb 19, 2024

App uses React 16. It's time to upgrade.

@paulsmirnov paulsmirnov added the dependencies Pull requests that update a dependency file label Feb 19, 2024
@paulsmirnov paulsmirnov added this to the v0.11.0 "Revival" milestone Feb 19, 2024
@paulsmirnov
Copy link
Member

It seems the application uses Redux incorrectly. It puts non-serialized objects into the store (e.g., Miew or ColorerList):

viewer = window.miew = new Miew({ container: domElement.current, load: '1crn' });
saveViewer(viewer);

const { colorers } = Miew;
saveColorers(colorers);

It also crashes (#514), but it seems unrelated.

I mean, it's difficult to upgrade and perform regression checks. I'll see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file miew-app
Projects
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants