Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color css variables must be rendered on app root element, not body (#4233) #4272

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Color css variables must be rendered on app root element, not body (#4233) #4272

wants to merge 1 commit into from

Conversation

Fsss126
Copy link
Contributor

@Fsss126 Fsss126 commented May 15, 2024

closes #4233

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@m0ksem m0ksem self-requested a review May 20, 2024 18:43
@m0ksem
Copy link
Contributor

m0ksem commented May 23, 2024

Let's fix conflicts and have experimental version for this feature...

@Fsss126 Fsss126 force-pushed the app-root-color-css-variables branch from 718ae5c to 995ce95 Compare June 2, 2024 08:48
@m0ksem
Copy link
Contributor

m0ksem commented Jun 3, 2024

I'll make a separate branch for this pr and others, please do not merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0ksem m0ksem m0ksem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Color css variables must be rendered on app root element, not body
2 participants
@Fsss126 @m0ksem