Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes sense to substitute Express for Fastify? #670

Closed
rustworthy opened this issue Mar 24, 2024 · 3 comments
Closed

Makes sense to substitute Express for Fastify? #670

rustworthy opened this issue Mar 24, 2024 · 3 comments

Comments

@rustworthy
Copy link
Contributor

Hi there!

This is an awesome stack and a lot of efforts and time invested for the community benefit.

I'd like to suggest something. How about switching onto fastify, which is a new generation framework and
could fit the epic stack nature ideally. Here is short summary from Nest.js documentation on the underlying framework, which is of interest I believe.

There's a community maintained remix-fastify adapter and one missing piece - the wrapper over the wrapper 😅 in Sentry - I hope will be covered soon. As for the middleware used in the epic stack's Express server app - a quick walk-through shows they are all available in Fastify ecosystem.

It goes without saying, there should be a proof of concept first, which I'd love to implement and tag accordingly 😄

What's your opinion on this change suggestion in general?

@fredericrous
Copy link
Contributor

my humble opinion, epic stack should wait for fastify to become a remix official adapter. switching to a community driven adapter doesn't seem wise for a broad usage for the number 1 template for remix. But that shouldn't stop you from forking the template and creating a PR to add it to https://github.com/epicweb-dev/epic-stack/blob/main/docs/examples.md

@kiliman
Copy link
Contributor

kiliman commented Mar 25, 2024

My understanding is that the Remix team is not interested in creating more official adapters. They want to offload that responsibility to the platform owners or community.

@kentcdodds
Copy link
Member

An example would definitely be welcome.

I'm not very interested in changing the built-in server until Remix finishes the work they're doing on solving "the middleware problem." Because when they do then we'll ditch the built-in server in favor of using Remix for everything anyway.

Express is good enough to get us to that point.

Here's an old discussion about this. Feel free to move further discussion here: #511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants