Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird interaction with fish #98

Open
agracey opened this issue Jan 6, 2022 · 1 comment
Open

Weird interaction with fish #98

agracey opened this issue Jan 6, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@agracey
Copy link

agracey commented Jan 6, 2022

First off, this tool is amazing and has already helped me solve multiple issues! Also, your code is nicely readable even by someone like me who really dislikes golang!

In fish, if I run without the timeout specified, the span doesn't write to the collector and the program returns shortly with an exit code of 0 (even with the &). This stumped me for a while until I found that setting the timeout to some very high number does exactly what I need.

I've confirmed that the same command that breaks in fish work flawlessly when I switch to bash without any other env change. Which is weird... I wonder if fish does some extra fork/redirection?

@tobert
Copy link
Member

tobert commented Aug 9, 2022

Oh interesting. I'll mark this a bug and see if I can reproduce.

In the mean time, if you get a chance, please try again with the --verbose --fail flags? By default otel-cli tries really hard to not return error codes or do anything that would make e.g. set -eo pipefail users have a bad time.

@tobert tobert added the bug Something isn't working label Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants