Skip to content
This repository has been archived by the owner on Nov 19, 2020. It is now read-only.

Expose raw API calls for logs, exec, etc. #11

Open
ericchiang opened this issue Jan 9, 2017 · 7 comments
Open

Expose raw API calls for logs, exec, etc. #11

ericchiang opened this issue Jan 9, 2017 · 7 comments

Comments

@ericchiang
Copy link
Owner

No description provided.

@leosunmo
Copy link

I would love the ability to send commands to running pods. Would solve a lot of problems for me. Big thumbs up!

@ericchiang
Copy link
Owner Author

I'm actually struggling to find a spec on how attach is implemented. Do you have any links in the core repo?

@chancez
Copy link

chancez commented Mar 30, 2017

They have their own protocol built on top of http2, most of the core pieces are in k8s.io/apimachinery/pkg/util/httpstream for how they do the protocol negotiation/versioning and the actual http2 bits. k8s.io/kubernetes/pkg/client/unversioned/remotecommand has the protocol on top.

@sttts
Copy link

sttts commented Mar 30, 2017

In addition there is a WebSocket variant since 1.6, if that is easier to support.

@ericchiang
Copy link
Owner Author

ericchiang commented Mar 30, 2017

@chancez to the best of my understanding it's a SPDY upgrade, not HTTP/2.

@sttts since this client enables HTTP/2 I don't think Go will let the API server hijack the connection and switch to websockets.[0]

Maybe upstream would accept the PRs if I could get exec working over an HTTP/2 stream? :)

[0] https://golang.org/pkg/net/http/#Hijacker

@ericox
Copy link

ericox commented Aug 10, 2018

Did exec over an HTTP/2 stream end up working?

@ericchiang
Copy link
Owner Author

ericchiang commented Aug 11, 2018 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants