Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Select All" prop #821

Open
fablexis91 opened this issue Oct 5, 2023 · 4 comments
Open

"Select All" prop #821

fablexis91 opened this issue Oct 5, 2023 · 4 comments

Comments

@fablexis91
Copy link

fablexis91 commented Oct 5, 2023

Is your feature request related to a problem? Please describe.

It would be nice to have the option of "Select All" for picking all the menu options. I know that we have available the prop renderMenu, but in order to see the "Select All" working as expected without replacing the use of MenuItem, that should be part of the options prop value, otherwise when clicking on it we will get an error like this:

Uncaught TypeError: Cannot read properties of undefined (reading 'paginationOption')

So, there's no way to use an option that does not belong to the options prop without being part of the entire data

Describe the solution you'd like
it would be nice to have a prop that receives a boolean value that can turn on this feature of selecting all of the menu items

Does your feature address a common use case? Does it provide a more generalized way to solve the type of problem you're encountering?

I think for a large amount of data (let's say 15 items, which actually is not that big), if the user wants to select all the records, by default they will have to pick each item... which is kinda tedious

@gnsoria
Copy link

gnsoria commented Oct 13, 2023

Yes! Please add this!

Here's my use case: My typeahead contains dozens of options (usually between 40 and 100). Users can filter with a variety of keywords, but this often still leaves them with a dozen or more filtered options. Especially on mobile, it can be difficult to select everything, especially since their keyword is cleared after each selection. For example, they'd have to type "SP", select an option, type "SP", select an option, maybe a dozen times.

It also might be easier for my users to select all, and then deselect options they don't want using the tokens.

It would be great to be able to toggle on a menu item at the top of the menu that says "Select All" and then adds all filtered options to the selections.

@Nathan-Roberts123
Copy link

yn3gf

You mean something like this???

@Nathan-Roberts123
Copy link

I added this feature in my local source code, I need the project manager to assign me to the issue so I can make a contributions.

@gnsoria
Copy link

gnsoria commented Feb 15, 2024

@ericgio Any chance you could work with @Nathan-Roberts123 to get their solution implemented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants