Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(watch): relative paths in --ignore flag #115

Conversation

romanlamsal
Copy link
Contributor

@romanlamsal romanlamsal commented Oct 7, 2022

When using relative paths with watch --ignore, chokidar won't pick up the correct files.

The existing test is refactored to use relative paths instead of absolute paths to ignore and execute.

The fix is to explicitly provide a cwd to chokidar.

Reproduction: open stackblitz, run pnpm dev and change something in ignored.js. tsx should not rerun, but does.

tests/specs/watch.ts Outdated Show resolved Hide resolved
@privatenumber privatenumber changed the title fix: watch --ignore with relative paths fix(watch): relative paths in --ignore flag Oct 7, 2022
@privatenumber privatenumber merged commit 332f242 into privatenumber:develop Oct 7, 2022
@privatenumber
Copy link
Owner

🎉 This PR is included in version 3.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@privatenumber
Copy link
Owner

Thanks for the fix @romanlamsal

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants