Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(watch): remove dist from ignore #141

Merged
merged 2 commits into from Nov 12, 2022
Merged

fix(watch): remove dist from ignore #141

merged 2 commits into from Nov 12, 2022

Conversation

privatenumber
Copy link
Owner

Problem

dist directory was ignored from watch. This made it difficult to pair tsx with programs that built source files.

For example, when developing an ESLint config, ESLint handles loading the config modules, so they must be built to CommonJS. (There's no way to override the default require hook because ESLint tries to handle different extensions on its own.) When testing the config, the test files would be importing from the dist directory.

Changes

Remove dist from watch ignore list.

@privatenumber privatenumber merged commit eae2663 into develop Nov 12, 2022
@privatenumber privatenumber deleted the watch-dist branch November 12, 2022 03:12
@privatenumber
Copy link
Owner Author

🎉 This PR is included in version 3.12.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant