Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repl): suppress autocomplete transformation errors #205

Merged
merged 2 commits into from Mar 20, 2023

Conversation

privatenumber
Copy link
Owner

@privatenumber privatenumber commented Mar 20, 2023

Node.js passes in the code snippet to evaluate before pressing Enter:
https://github.com/nodejs/node/blob/bc0aa359384f66150f33d4943023ff2c55365dbd/lib/repl.js#L1496

When incomplete code is passed in, transformation fails and shows an error. However, these errors can simply be ignored.

fix #204
also fixes part of #202

@privatenumber privatenumber mentioned this pull request Mar 20, 2023
1 task
@privatenumber privatenumber merged commit 8e1958d into develop Mar 20, 2023
2 checks passed
@privatenumber privatenumber deleted the fix-204 branch March 20, 2023 17:26
@privatenumber
Copy link
Owner Author

🎉 This PR is included in version 3.12.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Unterminated string literal" error in REPL
1 participant