Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(watch): check child message data to be an object #224

Merged
merged 2 commits into from Apr 30, 2023

Conversation

pedablio
Copy link
Contributor

No description provided.

@privatenumber
Copy link
Owner

Is there a specific problem you're addressing?

@pedablio
Copy link
Contributor Author

I'm having problem using watch mode
It seems that when receiving the dependencies by
runProcess.on('message', (data) => {
The variable data also receives a string with the text 'ready' in my case
Giving the error: Cannot use 'in' operator to search for 'type' in ready

@endel
Copy link

endel commented Apr 29, 2023

I'm also getting this error when running tsx watch src/index.ts:

Cannot use 'in' operator to search for 'type' in ready

The piece of code that seems to be related to this issue come from these files:

node_modules/chalk/node_modules/supports-color/index.js
84:		if (['TRAVIS', 'CIRCLECI', 'APPVEYOR', 'GITLAB_CI', 'GITHUB_ACTIONS', 'BUILDKITE'].some(sign => sign in env) || env.CI_NAME === 'codeship') {

node_modules/supports-color/index.js
97:		if (['TRAVIS', 'CIRCLECI', 'APPVEYOR', 'GITLAB_CI', 'GITHUB_ACTIONS', 'BUILDKITE', 'DRONE'].some(sign => sign in env) || env.CI_NAME === 'codeship') {

src/watch/utils.ts Outdated Show resolved Hide resolved
@privatenumber privatenumber changed the title Fix isDependecyPath with ready message fix(watch): check child message data to be an object Apr 30, 2023
@privatenumber privatenumber merged commit 5366c31 into privatenumber:master Apr 30, 2023
2 checks passed
@privatenumber
Copy link
Owner

🎉 This PR is included in version 3.12.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

privatenumber added a commit that referenced this pull request Apr 30, 2023
Co-authored-by: Hiroki Osame <hiroki.osame@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants