Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(watch): wait for the process to exit #298

Merged
merged 14 commits into from Sep 1, 2023
Merged

fix(watch): wait for the process to exit #298

merged 14 commits into from Sep 1, 2023

Conversation

privatenumber
Copy link
Owner

@privatenumber privatenumber commented Aug 31, 2023 •
edited

fix #82

  • When hitting Enter
    • If the child process is not running, it simply re-runs it
    • If the child process is running, it kills it and waits for it to exit
      • If Enter is hit again while the child process is exiting, it force-kills it

@privatenumber privatenumber mentioned this pull request Sep 1, 2023
Closed
@privatenumber privatenumber marked this pull request as ready for review September 1, 2023 10:22
@privatenumber privatenumber merged commit a4cb800 into develop Sep 1, 2023
2 checks passed
@privatenumber privatenumber deleted the watch-wait-exit branch September 1, 2023 10:30
@privatenumber
Copy link
Owner Author

🎉 This PR is included in version 3.12.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@stephenh
Copy link
Sponsor

stephenh commented Sep 1, 2023

Awesome! Thanks @privatenumber ! Will check this out later today...

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid address-already-in-use errors when using watch & inspect
2 participants
@privatenumber @stephenh