Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pension / Bituach Ishtalmut / Insurance #770

Open
amir-daniel opened this issue Apr 13, 2023 · 11 comments
Open

Pension / Bituach Ishtalmut / Insurance #770

amir-daniel opened this issue Apr 13, 2023 · 11 comments

Comments

@amir-daniel
Copy link

amir-daniel commented Apr 13, 2023

I would like to write a new scraper for some pension / insurance companies. Is this something desirable for us?

@erikash
Copy link
Collaborator

erikash commented Apr 16, 2023

TBH - I think it's out of the scope of this library as it's outside the banking segment (scraping securities data such as stocks and bonds would be welcome)

If you're interested, I've founded Mukdam which will expose this data as an API at some point :)
We use Masleka data as we're a licensed insurance broker.
For now it's just a monthly report and some other insights delivered to you...

https://www.mukdam.co.il

@baruchiro
Copy link
Collaborator

I see @eshaham started this some time, you may continue :-)
https://github.com/eshaham/israeli-insurance-scrapers

@eshaham
Copy link
Owner

eshaham commented Apr 23, 2023

I just deleted it - it had nothing in it, just a skeleton project 😞

@Wazzaps
Copy link

Wazzaps commented Apr 28, 2023

I get my data directly from the Masleka (https://www.swiftness.co.il), I intercept the ZIP they send every month to my gmail with the gmail api, then parse the XLS inside (much easier than the XML), and store inside sqlite.
Would you like the code for that?

@erikash
Copy link
Collaborator

erikash commented Apr 28, 2023 via email

@Wazzaps
Copy link

Wazzaps commented Apr 28, 2023

Here's my project: https://github.com/Wazzaps/stonks
It's structured as a RESTful api (rather than a library) since that's how I use it, but you can extract that part out.
The interesting part is translating all the keys (which are in hebrew/hebrish) to english, so they can be stored in a DB.
I consume the DB directly with Grafana, my dashboard JSON is attached.

Since I don't have access to the proper APIs (thanks """Open""" banking), I scrape the monthly zip from swiftness that's delivered to my email.

@esakal
Copy link
Collaborator

esakal commented May 2, 2023

Hi @Wazzaps, I like your nickname! Thank you for your suggestion. I agree with @erikash that your idea seems to be outside the scope of this library. However, in general, the library is not too opinionated and allows you to scrape relevant financial information.

I do have a technical concern, though. As the library is not modularized as we hoped, implementing your suggestion may introduce new behaviors, such as using a path to a zip file instead of credentials or skipping the login phase. While this is not critical, it does align with Erik's opinion about the relevance of your suggestion to this library. Additionally, the library will mainly be used as a converter from xls to csv.

I'm open to your suggestion, but I agree that it may not be highly relevant to this library. Does anyone else have an opinion on this? @eshaham @baruchiro?

@Wazzaps
Copy link

Wazzaps commented May 2, 2023

The main problem with signing in to swiftness directly (though it is possible), is they remove the data after some time due to privacy laws.

I guess this is not too different from how most banks work, so it's feasible.

In any case, I think the XLS -> Dict translation somewhat fits the theme of the library, acting as a common language for all providers.

There are probably in-memory zip and XLS libraries for node.js, so working with paths might not even be necessary.

@baruchiro
Copy link
Collaborator

I don’t think pension and insurance should be part of the israeli-bank-scrapers project because, for example, they are not עו"ש.

However, because there is already a community here that has been built and will probably also be interested in the pension and insurance project, I recommend putting references from the current project to the new project.

@tomerh2001
Copy link

+1

Looking for a solution to integrate with Firefly III. Awesome project btw!

@tomerh2001
Copy link

tomerh2001 commented Mar 24, 2024

Does anyone know an existing scraper for Clal's Pension / Keren Ishtalmut?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants