Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bad description on error when scrapping isracard #788

Open
liranelisha opened this issue May 19, 2023 · 0 comments
Open

bad description on error when scrapping isracard #788

liranelisha opened this issue May 19, 2023 · 0 comments
Labels
help wanted

Comments

@liranelisha
Copy link

liranelisha commented May 19, 2023 •
edited

description

before scrapping there should be validation that all mandatory fields exists in the given JSON. this isn't seems to be the case for isracard

expected behavior

scrapping isracard without the card6Digits or any other field will generate a readable and actionable message.

actual behavior

when scrapping isracard card without the card6Digits field i'm getting errorType=GENERIC and errorMessage='Evaluation failed: SyntaxError: Unexpected end of JSON input\n at __puppeteer_evaluation_script__:16:26'
@liranelisha liranelisha closed this as not planned Won't fix, can't repro, duplicate, stale May 19, 2023
@liranelisha liranelisha reopened this May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@esakal @liranelisha