Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAL scraper should retrieve pending transcations #791

Open
galbarm opened this issue Jun 17, 2023 · 9 comments · May be fixed by #794
Open

CAL scraper should retrieve pending transcations #791

galbarm opened this issue Jun 17, 2023 · 9 comments · May be fixed by #794

Comments

@galbarm
Copy link

galbarm commented Jun 17, 2023

CAL launched a new website this week and surprisingly the scraper is still working.

Previously CAL showed only completed transactions but now on the new website they also show pending transactions.
These pending transactions are currently not returned by the scraper.

The scraper should be updated to retrieve the pending transactions as well.

@galbarm galbarm changed the title CAL scrapper can now support pending transcations CAL scraper can now support pending transcations Jun 17, 2023
@galbarm galbarm changed the title CAL scraper can now support pending transcations CAL scraper should retrieve pending transcations Jun 17, 2023
@niv280
Copy link

niv280 commented Jun 22, 2023

HI, it's not working for me, it's stuck after the login when the new UI ad pop and then I get Timeout error.
You didn't encounter this?

@galbarm
Copy link
Author

galbarm commented Jun 23, 2023

HI, it's not working for me, it's stuck after the login when the new UI ad pop and then I get Timeout error. You didn't encounter this?

No.
Surprisingly it's working properly for me.
I even set showBrowser: true to verify that it is the new website which gets opened.

@esakal
Copy link
Collaborator

esakal commented Jun 30, 2023

Hi @galbarm @niv280
Is this issue still relevant or can we close it?

@galbarm
Copy link
Author

galbarm commented Jun 30, 2023

@esakal hi, please don't close.
The issue is relevant and I will create a PR for it soon.

@niv280
Copy link

niv280 commented Jun 30, 2023

For me it's not working at all, I'm getting Timeout error inside getLoginFrame func.
Should I open separate issue about it?

@galbarm
Copy link
Author

galbarm commented Jun 30, 2023

@niv280 yes. this issue is only for supporting pending transactions

@galbarm galbarm linked a pull request Jun 30, 2023 that will close this issue
@amir-daniel
Copy link

still relevant? if needed I can chime in and send a PR

@gbarmashiahflir
Copy link

@amir-daniel it has a PR waiting for several month:
#794

@amir-daniel
Copy link

@esakal @eshaham what's the status on this? I believe this would be very useful for many people, and the PR is there, you just need to approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants