Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic Code Owners #830

Open
baruchiro opened this issue Feb 5, 2024 · 8 comments
Open

Automatic Code Owners #830

baruchiro opened this issue Feb 5, 2024 · 8 comments

Comments

@baruchiro
Copy link
Collaborator

baruchiro commented Feb 5, 2024

UPDATE: still open, see #830 (comment)

Hi everyone,

I just joined to be a maintainer in this lovely project 馃挅

Sometimes there are PRs here that wait for a long time because we can't test them without the relevant account.

I had an idea about a list of Code Owners- developers that accept to be tagged when there is a change in a bank they can help to test.

If you want to be notified and help us to test changes, please leave a message with the relevant bank accounts here.

Thank you!

Bank Owners
Mizrahi @baruchiro
Cal @baruchiro @galbarm @daniel-hauser
Isracard @baruchiro @galbarm @daniel-hauser
Max @baruchiro @galbarm @daniel-hauser @dimdimi4
Discount @galbarm
Hapoalim @galbarm @daniel-hauser
Amex @daniel-hauser
Behatsdaa @daniel-hauser
Yahav @gczobel
Mercantile @EzzatQ @kfirarad
Leumi @dimdimi4

See the updated list on component_owners.yml

@galbarm
Copy link

galbarm commented Feb 5, 2024

Hi, I can help testing Cal, Max, Isracard, Discount & Hapoalim

@baruchiro baruchiro pinned this issue Feb 5, 2024
@daniel-hauser
Copy link
Contributor

@baruchiro I can help with Hapoalim, Cal, Max, Isracard, Amex and Behatsdaa

@gczobel
Copy link
Contributor

gczobel commented Feb 8, 2024

I can help with Bank Yahav.

@baruchiro
Copy link
Collaborator Author

Missing code owners for
Beinleumi (@dudiventura?)
Leumi (@esakal?)
Beyahad-Bishvilha (@esakal?)
One-Zero (@orzarchi?)
Otzar-Hahayal (@matanelgabsi?)
Union-Bank

@dimdimi4
Copy link
Contributor

I can help with Leumi and Max.

baruchiro added a commit to baruchiro/israeli-bank-scrapers that referenced this issue Mar 12, 2024
Copy link

馃帀 This issue has been resolved in version 4.3.0 馃帀

The release is available on GitHub release

Your semantic-release bot 馃摝馃殌

@nisan-tagar
Copy link
Contributor

I can help with FIBI bank.

@baruchiro baruchiro changed the title Call for Code Owners Automatic Code Owners Mar 31, 2024
@baruchiro
Copy link
Collaborator Author

I made a mistake in #836. The dyladan/component-owners require the accounts to be collaborators to this project, but this is not our case.

We must create an automatic script to tag the relevant people on an issue/PR comment. (see #835)

@baruchiro baruchiro reopened this Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants