Fix false positives with violation reporting helper function in no-unused-message-ids rule
#290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
force-pushed
the
no-star-message-ids-fn-param
branch
3 times, most recently
from
bdb9cb8
to
110e0c0
Compare
bmish
changed the title
no-missing-message-ids and no-unused-message-ids rulesno-unused-message-ids rule
…unused-message-ids` rule
bmish
force-pushed
the
no-star-message-ids-fn-param
branch
from
110e0c0
to
ef20d99
Compare
ddzz
approved these changes
Aug 15, 2022
aladdin-add
approved these changes
Aug 15, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
messageIdfrom a function parameter is reported, stop trying to detect unusedmessageIds, since we can't currently know what values that function is called with. In a future improvement, we could try to detect the function calls to find the possible values the parameter is called with.Fixes #282.