Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeScript type-checking to all rules #310

Open
bmish opened this issue Oct 7, 2022 · 0 comments
Open

Add TypeScript type-checking to all rules #310

bmish opened this issue Oct 7, 2022 · 0 comments
Labels
javascript Pull requests that update Javascript code

Comments

@bmish
Copy link
Member

bmish commented Oct 7, 2022 •
edited

We don't need to convert our JavaScript files to TypeScript, but by adding JSDoc comments with types and using the TypeScript checkJs option, we can get the benefits of type-checking. See this PR for an example and list of benefits: square/eslint-plugin-square#723.
@bmish bmish added the javascript Pull requests that update Javascript code label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bmish