Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule: report locations should be based on ESTree node ranges #328

Open
JoshuaKGoldberg opened this issue Nov 12, 2022 · 0 comments
Open

Comments

@JoshuaKGoldberg
Copy link
Contributor

From typescript-eslint/typescript-eslint#4796:

Following typescript-eslint/typescript-eslint#4723 and typescript-eslint/typescript-eslint#4790, it looks like we need to might need to always report fixer ranges using the ES tree nodes rather than TypeScript nodes. If that's the case (is it?) we should lint to make sure we don't accidentally use a TypeScript node.

How about the rule use type information to check that if an object's property is provided as an argument to a fixer's range parameter, it should come from an ESTree node's .range

This partially reopens #6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant