Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: change test-case-property-ordering to add supports languageOptions #406

Merged
merged 3 commits into from
Apr 10, 2024
Merged

feat!: change test-case-property-ordering to add supports languageOptions #406

merged 3 commits into from
Apr 10, 2024

Conversation

aladdin-add
Copy link
Contributor

fixes #402

@aladdin-add
Copy link
Contributor Author

I don't think it will be a breaking change - parserOptions & langugeOptions cannot co-exists.

@aladdin-add aladdin-add marked this pull request as ready for review December 12, 2023 10:06
@bmish
Copy link
Member

bmish commented Dec 12, 2023

I believe it's a breaking change as anyone with flat rule tests that use languageOptions will suddenly have a new ordering of this property enforced.

@aladdin-add aladdin-add changed the title feat: change test-case-property-ordering to add supports languageOptions feat!: change test-case-property-ordering to add supports languageOptions Dec 13, 2023
@aladdin-add aladdin-add added the BREAKING CHANGE This change will require a major version bump label Dec 13, 2023
@aladdin-add aladdin-add requested a review from bmish April 9, 2024 07:03
@aladdin-add aladdin-add self-assigned this Apr 9, 2024
@aladdin-add aladdin-add marked this pull request as draft April 9, 2024 13:59
@aladdin-add aladdin-add marked this pull request as ready for review April 10, 2024 02:13
@aladdin-add aladdin-add merged commit 0dd0857 into main Apr 10, 2024
12 checks passed
@aladdin-add aladdin-add deleted the issue-402 branch April 10, 2024 02:15
@github-actions github-actions bot mentioned this pull request Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmish bmish bmish approved these changes

Assignees

@aladdin-add aladdin-add

Labels
BREAKING CHANGE This change will require a major version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support flat config properties for test-case-property-ordering
2 participants
@aladdin-add @bmish