feat: support named exports in ESM/TS

[43081j]

This adds support for named exports in ESM (whether it be TS or not).

For example:

export const rule: RuleModule = {
  create: () => { ... };
};

Also, exported symbols:

const rule = { ... };

export {rule};

While ESLint plugins are still usually CJS at time of writing this, many are written as ESM sources, and an increasing number are using named exports.

Reviewer notes

You'll want to hide whitespace changes when reviewing this, as prettier reformatted a bunch of it thanks to changing the level of nesting/chaining.

Fixes #375

[bmish]

Can you speak to the possibility of this causing additional false positives as I mentioned in #375 (comment)? Do you anticipate any? It may be worth testing on a few top ESLint plugins for a change like this. Is there anything else we should do to mitigate this from detecting named exports that aren't ESLint rules?

[aladdin-add]

According to the eslint-remote-tester's result, no false positives were found. We can start with this implementation and improve it if we receive feedback. thoughts?

https://github.com/eslint-community/eslint-plugin-eslint-plugin/actions/runs/7980943358/job/21791683343?pr=449

[aladdin-add]

A very primitive idea is allowing configuring the esquery selectors for the possible rules:

{
  settings: {
    // to allow "export const rule = ..."
    "eslint-plugin": {"rule-selectors": ["ExportNamedDeclaration[declaration.type="VariableDeclaration"][declaration.declarations.0.id.name="rule"]"]}
  }
}

[bmish]

@aladdin-add is eslint-remote-tester actually showing us new lint violations (which could be false positives), or just crashes? It says Results: No errors but I'd be kind of surprised if there really are no lint violations in any of those repositories. We may also want to add more ESM plugins to the list it tests against.

[bmish]

@43081j can you manually test this on a few larger/top ESM plugins? I don't think eslint-remote-tester, which runs during CI, detects false positives for us, only crashes.

[43081j]

i'll have a look into it 👍

[43081j]

Thanks for the quick review @bmish , I'll sort the changes tomorrow 👍

[43081j]

FYI i have at least resolved the two changes

not sure what you want to do about the testing. since it seems like @aladdin-add already ran the remote tester successfully

[43081j]

@bmish i ran it against:

• eslint-plugin-compat
• eslint-plugin-jest
• TSESLint
• eslint-plugin-vue
• eslint-plugin-prettier

and all seemed well

[bmish]

Thanks!