fix: no-callback-literal ignore unknown nodes (#163)

fixes #162
eslint-community · Jan 9, 2024 · 5fc2198 · 5fc2198
1 parent c191101
commit 5fc2198
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/lib/rules/no-callback-literal.js b/lib/rules/no-callback-literal.js
@@ -62,7 +62,8 @@ function couldBeError(node) {
         case "TaggedTemplateExpression":
         case "YieldExpression":
             return true // possibly an error object.
-
+        case "Literal":
+            return node.value == null
         case "AssignmentExpression":
             return couldBeError(node.right)
 
@@ -76,8 +77,7 @@ function couldBeError(node) {
 
         case "ConditionalExpression":
             return couldBeError(node.consequent) || couldBeError(node.alternate)
-
         default:
-            return node.value === null
+            return true // assuming unknown nodes can be error objects.
     }
 }
diff --git a/tests/lib/rules/no-callback-literal.js b/tests/lib/rules/no-callback-literal.js
@@ -6,6 +6,7 @@
 
 const RuleTester = require("eslint").RuleTester
 const rule = require("../../../lib/rules/no-callback-literal")
+const tsParser = require("@typescript-eslint/parser")
 
 const ruleTester = new RuleTester({ env: { node: true, es6: true } })
 ruleTester.run("no-callback-literal", rule, {
@@ -40,6 +41,11 @@ ruleTester.run("no-callback-literal", rule, {
         "cb(null)",
         'cb(undefined, "super")',
         'cb(null, "super")',
+        // https://github.com/eslint-community/eslint-plugin-n/issues/162
+        {
+            code: "cb(e as Error)",
+            languageOptions: { parser: tsParser },
+        },
     ],
 
     invalid: [