feat: add the ability to configure typescript to javascript file extension conversion #112
Conversation
|
This is draft because I am not sure how to add the mapping to n/file-extension-in-import, any suggestions? 🤔 |
|
@aladdin-add Do you want me to make the tsconfig detection mechanism PR now, or wait for you to review this PR? 👀 |
|
sorry, haven't gotten time to review. will try to do it in the week. :)
Yes, please feel free to. You can rebase this change when it's been merged. |
| @@ -69,13 +69,30 @@ If a path is relative, it will be resolved from CWD. | |||
|
|
|||
| Default is `[]` | |||
|
|
|||
| #### typescriptExtensionMap | |||
There was a problem hiding this comment.
To avoid duplication, I'm just wondering whether we could add a section to the readme that describes the shared settings. In the rule docs we can add a link to that. (surely not blocking merging this PR. 😄 )
| option && | ||
| option.typescriptExtensionMap && | ||
| Array.isArray(option.typescriptExtensionMap) |
There was a problem hiding this comment.
nits: can be simply rewritten to Array.isArray(option?.typescriptExtensionMap), as the package has dropped node.js < v16.
There was a problem hiding this comment.
Oh, I am totally going to fix this in another PR!
I just followed what was there 👀
Reference #108
This adds the ability to configure the ts<>js extension mapping.
This is configured using the following:
typescriptExtensionMapnode.typescriptExtensionMap.ts<=>.js,.cts<=>.cjs,.mts<=>.mjs,.tsx<=>.js