feat: supported new globals added in the new node.js versions #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For eslintrc configs, using the 'env' property; for flat configs, reference the npm package 'globals'.
kevinoid
added a commit
to kevinoid/mocha-ur2ue
that referenced
this pull request
Dec 31, 2023
eslint-community/eslint-plugin-n#154 removed many global variables from eslint-plugin-n in favor of enabling the node and es2021 environments. Since we disable the node environment (since our code may not be running in node) we need to declare those variables for linting. Do so as necessary. Bump the required version of eslint-plugin-n to ^16.5.0 to avoid warnings about redeclaring globals when using previous versions. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For eslintrc configs, using the 'env' property;
for flat configs, reference the npm package 'globals'.